-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neighbor state #3191
base: master
Are you sure you want to change the base?
Add neighbor state #3191
Conversation
Signed-off-by: Emin Umut Gercek <[email protected]>
74f1c6f
to
4a7715d
Compare
Signed-off-by: Emin Umut Gercek <[email protected]>
4a7715d
to
2246604
Compare
…-arp-states Signed-off-by: Emin Umut Gercek <[email protected]>
de8539a
to
d679000
Compare
Also fixed the merge conflict. |
|
||
for _, n := range neighbors { | ||
// Skip entries which have state NUD_NOARP to conform to output of /proc/net/arp. | ||
if n.State&unix.NUD_NOARP == 0 { | ||
entries[n.Interface.Name]++ | ||
if n.State&unix.NUD_NOARP != unix.NUD_NOARP { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I can say?
if n.State&unix.NUD_NOARP != unix.NUD_NOARP { | |
if n.State != unix.NUD_NOARP { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, n.State
is a bit mask. The bitwise AND is necessary to isolate the NUD_NOARP
flag that we wish to test for. Other bits may be set in n.State
, so you cannot just do a simple comparison as you suggest.
cf. man 7 rtnetlink
:
ndm_state is a bit mask of the following states:
NUD_INCOMPLETE a currently resolving cache entry
NUD_REACHABLE a confirmed working cache entry
NUD_STALE an expired cache entry
NUD_DELAY an entry waiting for a timer
NUD_PROBE a cache entry that is currently reprobed
NUD_FAILED an invalid cache entry
NUD_NOARP a device with no destination cache
NUD_PERMANENT a static entry
Implements part of #535
Some things we can talk:
state="stale"
like labels and just give the state value to Gauge (IMO current impl is simpler) although I saw below in CONTRIBUTING.md I didn't see many magic numbers in the metrics and labels thus added human readable names for them.Update
function to make it more readable (again IMO it's simple enough to do it in one function)This pr adds below metrics
Old comments
I changed the design in second commit due to not exploding cardinality but keep the comments if maintainers wants that design.
Iff you want to have metrics like below, can continue to read:
Some things we can talk:
neighborState
struct and just use string slice, but this is easier to follow IMO1024*count(net_int)
as max. But in some "fine tuning"s I saw people generally increase this although it's limited by the size of you subnet, one can have many machines in subnet. Maybe I should make a counter for each state?@SuperQ it's ready for your review, when you have time 🙏🏻